Implement IDbContextFactory to work around aspnet/EntityFramework#8164 #695
Conversation
|
I haven't tested this yet; I just wanted to get it out there for early review. |
|
Only thing I don't know is whether there ought to be a comment on there. I'd add one only if it provided real value, as opposed to stating the obvious. |
| using System.Threading.Tasks; | ||
| using Microsoft.EntityFrameworkCore.Infrastructure; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using Company.WebApplication1.Models; |
There was a problem hiding this comment.
Will remove this using.
| public class ApplicationDbContextFactory : IDbContextFactory<ApplicationDbContext> | ||
| { | ||
| public ApplicationDbContext Create(DbContextFactoryOptions options) | ||
| => Program.BuildWebHost(Array.Empty<string>()) |
There was a problem hiding this comment.
Move the => to the end of the declaring line
There was a problem hiding this comment.
...and format it like this?
public ApplicationDbContext Create(DbContextFactoryOptions options) => Program
.BuildWebHost(Array.Empty<string>())
.Services
.GetRequiredService<ApplicationDbContext>();There was a problem hiding this comment.
(to match Program.BuildWebHost)
There was a problem hiding this comment.
Egad, no, like this:
public ApplicationDbContext Create(DbContextFactoryOptions options) =>
Program.BuildWebHost(Array.Empty<string>()).Services.GetRequiredService<ApplicationDbContext>();
|
Updated |
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.EntityFrameworkCore.Infrastructure; |
There was a problem hiding this comment.
Kind of an odd namespace for this apparently very useful type... but I guess that's not relevant to this PR...
bricelam
changed the title
|
@mlorbetske I wish you would have waited to merge this; dotnet/efcore#8314 will break this... Oh well, I'll send a new PR when it does. |
|
Sorry, got the go ahead from @ajcvickers & @DamianEdwards |
|
Ahem, I believe I asked you to check with @bricelam first 🤔 |
|
No biggie. Sent #705 |
|
@DamianEdwards I tried to but got redirected. Anyway, it seems to be working out. |
@Eilon @ajcvickers @DamianEdwards @divega @danroth27