[2.0.0-preview1] Remove DbContextFactoryOptions #8314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2017
bricelam
commented
Apr 28, 2017
| /// <returns> An instance of <typeparamref name="TContext" />. </returns> | ||
| TContext Create([NotNull] DbContextFactoryOptions options); | ||
| TContext Create([NotNull] string[] args); |
There was a problem hiding this comment.
Should this be IEnumerable<string>?
There was a problem hiding this comment.
Should I call ToArray in the templates or push for IEnumerable all the way down?
There was a problem hiding this comment.
There might also be value in keeping an array to mirror Main and drive home the point that this is an entry point into the application
There was a problem hiding this comment.
It looks like both WebHost.CreateDefaultBuilder and IConfigurationBuilder.AddCommandLine (which it calls) are string[]. Given that, I think we should keep it string[].
There was a problem hiding this comment.
I'm fine with keeping an array for that reason.
This was referenced Apr 28, 2017
divega
approved these changes
Apr 28, 2017
| /// <returns> An instance of <typeparamref name="TContext" />. </returns> | ||
| TContext Create([NotNull] DbContextFactoryOptions options); | ||
| TContext Create([NotNull] string[] args); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8164