-
Notifications
You must be signed in to change notification settings - Fork 59
Update Windows.Compatibility external packages #4884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before .NET 10 is released, we will have a 10.x version. But for now that's the correct version. We'll be releasing the 10.x version nearer to the release of .NET 10. |
Do these packages retain support for .NETStandard and .NETFramework? |
Also seems the latest version of System.ServiceModel.Security and System.ServiceModel.Duplex on nuget is 6.0.0. |
After this version System.ServiceModel.Security and System.ServiceModel.Duplex no longer exist.
Kind of. They have netstandard2.0 reference assemblies, netfx type forwarding facades, netfx compat shim (System.ServiceModel.dll which type forwards to System.ServiceModel.* assemblies), a net8.0 implementation (and the 10,x version would have a .Net10 implementation), and a dummy implementation for netstandard2.0. Remember that every framework that supports netstandard2.0 ships an implementation in box except .NET so we don't need a netstandard2.0 implementation if we have have NetFx and .NET runtime support. |
We flattened Security and Duplex into Primitives as Primitives implementation needed access to those types when I got rid of System.Private.ServiceModel.dll. The Primitives package ships with type forwarding facades for Duplex and Security to accommodate libraries that still reference them if they were compiled against an older version. Those assemblies are only runtime forwarding facades, we got rid of the reference assemblies as their types are now in the Primitives ref assembly. |
What is the background for these changes? Moving to the supported versions? |
System.Data.SqlClient is now deprecated and not supported on .NET 10 onwards. Ref: dotnet/SqlClient#2778 Please migrate to the Microsoft.Data.SqlClient NuGet package. You may backport this update to 4.9.0 for .NET 9 and .NET 8 while they are in support. |
FIxes #4885 |
This package should not include Microsoft.Data.SqlClient since that's not part of .NETFramework surface area. The purpose of M.W.C is to bring assemblies that implement the actual types from .NETFramework that aren't inbox on .NETCore. It is not meant to "advertise" new types/packages that were not part of .NETFramework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestion
/backport to release/8.0 |
* Update Windows.Compatibility external packages ServiceModel is updated to 8.1.1, in this version System.ServiceModel.Security and System.ServiceModel.Duplex no longer exist, their types (type forwards) are in the primitives package. Microsoft.Data.SqlClient NuGet package to 4.9.0 --------- Co-authored-by: Tanya Solyanik <[email protected]>
* Update Windows.Compatibility external packages ServiceModel is updated to 8.1.1, in this version System.ServiceModel.Security and System.ServiceModel.Duplex no longer exist, their types (type forwards) are in the primitives package. Microsoft.Data.SqlClient NuGet package to 4.9.0 --------- Co-authored-by: Tanya Solyanik <[email protected]>
From @HongGit
|
@cheenamalhotra - SQLClient
@HongGit @StephenMolloy @mconnew - WCF client
Please review if these dependency changes are correct for .NET 10.0.
Also please comment on what changes, if any, would be appropriate to backport to
net9.0
ornet.8.0
.