Skip to content

[release/9.0] Update Windows.Compatibility external packages. #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/9.0
Choose a base branch
from

Conversation

Tanya-Solyanik
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik commented Jan 30, 2025

Related to #4884

Description:

Microsoft.Windows.Compatibility NuGet v8.0.12 carries 3 assemblies(System.Data.SqlClient.dll, System.Diagnostics.EventLog.Messages.dll, and System.ServiceModel.dll)) that do not have symbols on the Microsoft symbol server.

Fix:

System.Data.SqlClient.dll and System.ServiceModel.dll – updated to a newer compatibility packages that have symbols
System.Diagnostics.EventLog.Messages.dll – pdbs were added to the package in the above mentioned PR, and will flow to Microsoft.Windows.Compatibility as a servicing update

Followup bugs

Symbol package questions · Issue dotnet/runtime#15457 · dotnet/arcade
What is the expected workflow for Symbols Validation of official releases? · Issue dotnet/arcade#15537 · dotnet/runtime

Customer Impact:

Partner can’t debug their tests. They can’t upgrade. Windows partner has to store pdbs locally to be accessible for the duration of windows support term, which is longer that the .NET8’s. To achieve this goal they are down loading pdbs from the symbol server, their script breaks on our package.

Testing:

built the windows compatibility pack and verified that the right package versions are referenced.
Verified that the new partner packages have pdbs

Risk:

High - updating the major version of a dependency

* Update Windows.Compatibility external packages
ServiceModel is updated to 8.1.1, in this version System.ServiceModel.Security and System.ServiceModel.Duplex no longer exist, their types (type forwards) are in the primitives package.

Microsoft.Data.SqlClient NuGet package to 4.9.0

---------

Co-authored-by: Tanya Solyanik <[email protected]>
@Tanya-Solyanik Tanya-Solyanik changed the title [DO NOT MERGE] [release/8.0] Update Windows.Compatibility external packages. [DO NOT MERGE] [release/9.0] Update Windows.Compatibility external packages. Jan 30, 2025
@Tanya-Solyanik
Copy link
Member Author

Waiting to pick up version from dotnet/runtime#112139

@Tanya-Solyanik Tanya-Solyanik changed the title [DO NOT MERGE] [release/9.0] Update Windows.Compatibility external packages. Update Windows.Compatibility external packages. Feb 6, 2025
@Tanya-Solyanik Tanya-Solyanik changed the title Update Windows.Compatibility external packages. [release/9.0] Update Windows.Compatibility external packages. Feb 7, 2025
@ericstj
Copy link
Member

ericstj commented Feb 11, 2025

We should raise the risk level on this - it's updating the major version of a dependency - something we typically do not do in servicing.

Waiting to pick up version from dotnet/runtime#112139

@Tanya-Solyanik you don't need to wait on anything. That version should flow automatically, just like other runtime packages.

@Tanya-Solyanik
Copy link
Member Author

Per @mconnew and @HongGit we should take WCF Client 8.1.2 that contains the latest fixes

WCF team prepared a new version of client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Three referenced DLLs are missing PDBs on the Microsoft symbols server
2 participants