update TFM SDK, rev packages #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +29,11 @@ | |||
| <IncludeSymbols>false</IncludeSymbols> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup> | |||
| <!-- Disable warning in Nuget for references in Nuspec not matching refs (we do not use references element in our Nuspec) --> | |||
| <NoWarn>$(NoWarn);NU5131</NoWarn> | |||
There was a problem hiding this comment.
What's going on here - can you elaborate?
|
Why didn't we apply the same approach as #1684? |
In theory, this should use the same approach as netcoreapp5.0, with the following caveats:
You should have been able to do the above by cherry-picking the change from Finally, add-on workaround for NU5131 problems. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow