Skip to content

TFM Fixups for release/3.1 #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 11, 2019
Merged

TFM Fixups for release/3.1 #1835

merged 12 commits into from
Sep 11, 2019

Conversation

vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Sep 10, 2019 •
edited
Loading

Addresses #1804

A corresponding draft PR for dotnet-wpf-int can be found here.

@ghost ghost requested review from rladuca, ryalanms and stevenbrix September 10, 2019 23:24
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 10, 2019
@ghost ghost requested a review from SamBent September 10, 2019 23:24
@vatsan-madhavan vatsan-madhavan mentioned this pull request Sep 10, 2019
Closed
5 tasks
rladuca
rladuca suggested changes Sep 11, 2019
View reviewed changes
Copy link
Member

@rladuca rladuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-wpf.ps1 also needs changes for 3.1. Otherwise, it looks good to me.

rladuca
rladuca suggested changes Sep 11, 2019
View reviewed changes
Copy link
Member

@rladuca rladuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting back to request changes as more changes are coming.

@vatsan-madhavan vatsan-madhavan force-pushed the dev/vatsan/prep-rel31-tfm branch from 7a222fc to 7464387 Compare September 11, 2019 22:12
@vatsan-madhavan
Copy link
Member Author

copy-wpf.ps1 also needs changes for 3.1. Otherwise, it looks good to me.

we'll fix this in master over time. not strictly needed for release/3.1

@vatsan-madhavan vatsan-madhavan force-pushed the dev/vatsan/prep-rel31-tfm branch from 7464387 to c89578a Compare September 11, 2019 22:38
@vatsan-madhavan vatsan-madhavan force-pushed the dev/vatsan/prep-rel31-tfm branch from c89578a to 4941e49 Compare September 11, 2019 22:44
@vatsan-madhavan vatsan-madhavan marked this pull request as ready for review September 11, 2019 22:45
@vatsan-madhavan
Workaround for dotnet/installer#4744
7f91d7c 
            .NET Core 3.1 SDK hasn't consumed the fix for NuGet/Home#8467 yet.
            Suppress these warnings temporarily
@vatsan-madhavan
No not overwrite NoWarn - append to it
f6d7456
@vatsan-madhavan vatsan-madhavan force-pushed the dev/vatsan/prep-rel31-tfm branch from 4941e49 to f6d7456 Compare September 11, 2019 23:12
@vatsan-madhavan vatsan-madhavan merged commit 496c7e3 into release/3.1 Sep 11, 2019
@vatsan-madhavan vatsan-madhavan deleted the dev/vatsan/prep-rel31-tfm branch September 11, 2019 23:31
@vatsan-madhavan vatsan-madhavan mentioned this pull request Sep 12, 2019
Merged
@vatsan-madhavan vatsan-madhavan mentioned this pull request Nov 22, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rladuca rladuca rladuca approved these changes

@ryalanms ryalanms Awaiting requested review from ryalanms

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vatsan-madhavan @rladuca