Include "ResolveTargetingPackAssets" in AfterTargets; Remove unused Targets #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
vatsan-madhavan
approved these changes
Nov 22, 2019
|
Adding further cherry picks for nuget packaging issues. |
mmitche
approved these changes
Nov 22, 2019
mmitche
merged commit 0ac1ae1
into
dotnet:darc-release/3.0-a3262d79-668a-447f-baf4-f135ad5bfe7c
ghost
pushed a commit
that referenced
this pull request
Nov 22, 2019
* Update dependencies from https://github.com/dotnet/arcade build 20190924.3 - Microsoft.DotNet.ApiCompat - 1.0.0-beta.19474.3 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19474.3 - Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19474.3 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19474.3 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19474.3 * Update Nuget.config * Remove Versions.props restore sources * Attempt to remove dotnet-core, add dotnet3 and dotnet3-transport * Fix feed urls * Update NuGet.config * Update dependencies * Update test package version * Update dependencies from https://github.com/dotnet/arcade build 20191119.2 - Microsoft.DotNet.ApiCompat - 1.0.0-beta.19569.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19569.2 - Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19569.2 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19569.2 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19569.2 * Add reference to System.Resources.Extensions * Add System.Resources.Extensions references to PresentationUI * Revert "Add reference to System.Resources.Extensions" This reverts commit 6506e43. * Update dependencies * Include "ResolveTargetingPackAssets" in AfterTargets; Remove unused Targets (#2230) * Workaround for dotnet/installer#4744 .NET Core 3.1 SDK hasn't consumed the fix for NuGet/Home#8467 yet. Suppress these warnings temporarily * Fixing NoWarn to include SDK defines.
rladuca
deleted the
darc-release/3.0-a3262d79-668a-447f-baf4-f135ad5bfe7c
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting changes over from Release/3.1 into the DARC flow for Release/3.0.
Cherry-picked commits:
e1d79c0
MarkupCompilationPass1 getting too large a list of references which was causing a conflict between WindowsBase (the facade in NetCoreApp) and WindowsBase (the product assembly).
7f91d7c
NuGet changes here are creating errors in our packaging.