[release/3.0] Update dependencies from dotnet/arcade #1955

dotnet-maestro · 2019-09-25T16:37:00Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Build: 20191119.2
Date Produced: 11/19/2019 6:14 PM
Commit: e34d933e18ba1cd393bbafcb6018e0f858d3e89e
Branch: refs/heads/release/3.x
Updates:
- Microsoft.DotNet.ApiCompat -> 1.0.0-beta.19569.2
- Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19569.2
- Microsoft.DotNet.CodeAnalysis -> 1.0.0-beta.19569.2
- Microsoft.DotNet.GenAPI -> 1.0.0-beta.19569.2
- Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19569.2

…924.3 - Microsoft.DotNet.ApiCompat - 1.0.0-beta.19474.3 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19474.3 - Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19474.3 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19474.3 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19474.3

dotnet-maestro · 2019-09-25T16:42:03Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies No un-ignored checks.
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

NuGet.config

rladuca · 2019-09-25T23:33:31Z

NuGet.config

    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
-    <add key="dotnet-wd" value="https://dotnetfeed.blob.core.windows.net/dotnet-windowsdesktop/index.json" />


We need this feed, this contains WPF/WinForms transport packages.

These are also now automatically pushed to an azdo feed, and so should be able to be removed.

To be clear, the goal is to get down to:

nuget.org

Azdo feeds

I'm speculatively poking at some of this as I update these feeds now to get a head start.

Ah ok, sorry I was misunderstanding before and I saw the build error looking for WinForms.

I'm making similar changes in our test repo, so I'll wait on this for a final version before moving it there.

What is the mapping between these feeds and the AzDo transport feeds? For eg, which AzDo feed gets packages from the dotnet-windowsdesktop feed?

I like the idea of human understandable NuGet.config...

All dotnet 3 transport packages go to dotnet3-transport

All dotnet 3 non-transport (shipping) packages go to dotnet3

All dotnet 3.1 transport packages go to dotnet3.1-transport

All dotnet 3.1 non-transport (shipping) packages go to dotnet3.1

All dotnet 5 transport packages go to dotnet5-transport

All dotnet 5 non-transport (shipping) packages go to dotnet5

Arcade's tools go to dotnet-tools

There's no segregation between the various repos. That was largely a result of the scalability issues with the blob feed push.

…af4-f135ad5bfe7c

mmitche · 2019-09-26T17:30:15Z

@rladuca I added a subscription to the wpf test repo and updated the dependency

dotnet-maestro · 2019-09-26T17:31:20Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

mmitche · 2019-09-26T17:50:09Z

@vatsan-madhavan I think I got most necessary updates done here, but can you take a look at the remaining failures?

dotnet-maestro · 2019-09-26T17:51:28Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

mmitche · 2019-10-03T13:38:29Z

Don't merge this while we are shutting down 3.0.1

dotnet-maestro · 2019-10-03T13:40:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…af4-f135ad5bfe7c

mmitche

block until 3.0.1 finishes

mmitche · 2019-10-30T21:45:09Z

/azp run

azure-pipelines · 2019-10-30T21:45:19Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-maestro · 2019-10-30T21:47:25Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
❌ Standard Merge Policies There are reviews that have requested changes.

…119.2 - Microsoft.DotNet.ApiCompat - 1.0.0-beta.19569.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19569.2 - Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19569.2 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19569.2 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19569.2

…af4-f135ad5bfe7c

This reverts commit 6506e43.

…af4-f135ad5bfe7c

…argets (#2230)

mmitche · 2019-11-22T21:51:00Z

@rladuca Your changes now verifying here

rladuca · 2019-11-22T21:53:09Z

This will fail again in packaging. I need to merge some more fixups.

dotnet-maestro · 2019-11-22T21:54:09Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
❌ Standard Merge Policies There are reviews that have requested changes.

mmitche · 2019-11-22T21:54:25Z

This will fail again in packaging. I need to merge some more fixups.

Just push directly onto this branch as needed

.NET Core 3.1 SDK hasn't consumed the fix for NuGet/Home#8467 yet. Suppress these warnings temporarily

dotnet-maestro · 2019-11-22T21:59:12Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
❌ Standard Merge Policies There are reviews that have requested changes.

rladuca · 2019-11-22T22:15:45Z

Locally "build -ci -pack" succeeds, should be good to go.

dotnet-maestro · 2019-11-22T22:19:22Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
❌ Standard Merge Policies There are reviews that have requested changes.

mmitche · 2019-11-22T23:16:10Z

Yay!

dotnet-maestro · 2019-11-22T23:19:50Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
❌ Standard Merge Policies There are reviews that have requested changes.

ghost · 2019-11-22T23:26:29Z

Hello @vatsan-madhavan!

Because this pull request has the auto_merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost requested review from vatsan-madhavan, rladuca, ryalanms and stevenbrix September 25, 2019 16:37

ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 25, 2019

ghost requested a review from SamBent September 25, 2019 16:37

Update Nuget.config

ea4f260

rladuca reviewed Sep 25, 2019

View reviewed changes

NuGet.config Show resolved Hide resolved

rladuca reviewed Sep 25, 2019

View reviewed changes

NuGet.config Show resolved Hide resolved

mmitche added 2 commits September 25, 2019 14:08

Remove Versions.props restore sources

d8995c5

Attempt to remove dotnet-core, add dotnet3 and dotnet3-transport

4719312

rladuca reviewed Sep 25, 2019

View reviewed changes

mmitche added 5 commits September 25, 2019 16:49

Merge branch 'release/3.0' into darc-release/3.0-a3262d79-668a-447f-b…

f82920a

…af4-f135ad5bfe7c

Fix feed urls

244b4aa

Update NuGet.config

3a0abb3

Update dependencies

ff9dd07

Update test package version

9bcdddd

mmitche added the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 3, 2019

Merge branch 'release/3.0' into darc-release/3.0-a3262d79-668a-447f-b…

0acdab5

…af4-f135ad5bfe7c

mmitche removed the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 10, 2019

mmitche mentioned this pull request Oct 30, 2019

Investigate NuGet.Common load errors in Microsoft.DotNet.Build.Tasks.Feed dotnet/arcade#4235

Closed

mmitche requested changes Oct 30, 2019

View reviewed changes

dotnet-maestro bot and others added 9 commits November 20, 2019 19:39

Merge branch 'release/3.0' into darc-release/3.0-a3262d79-668a-447f-b…

c47612a

…af4-f135ad5bfe7c

Merge branch 'release/3.0' into darc-release/3.0-a3262d79-668a-447f-b…

cd28968

…af4-f135ad5bfe7c

Add reference to System.Resources.Extensions

6506e43

Add System.Resources.Extensions references to PresentationUI

5f52d8c

Revert "Add reference to System.Resources.Extensions"

1d21c89

This reverts commit 6506e43.

Update dependencies

98bce3f

Merge branch 'release/3.0' into darc-release/3.0-a3262d79-668a-447f-b…

5070c40

…af4-f135ad5bfe7c

Include "ResolveTargetingPackAssets" in AfterTargets; Remove unused T…

0ac1ae1

…argets (#2230)

Workaround for dotnet/installer#4744

291d880

.NET Core 3.1 SDK hasn't consumed the fix for NuGet/Home#8467 yet. Suppress these warnings temporarily

Fixing NoWarn to include SDK defines.

593086b

vatsan-madhavan approved these changes Nov 22, 2019

View reviewed changes

vatsan-madhavan added the auto_merge bot-command label Nov 22, 2019

ghost merged commit c3da7c1 into release/3.0 Nov 22, 2019

ghost deleted the darc-release/3.0-a3262d79-668a-447f-baf4-f135ad5bfe7c branch November 22, 2019 23:26

ghost locked as resolved and limited conversation to collaborators Apr 14, 2022

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/3.0] Update dependencies from dotnet/arcade #1955

[release/3.0] Update dependencies from dotnet/arcade #1955

dotnet-maestro bot commented Sep 25, 2019 •

edited

Loading

dotnet-maestro bot commented Sep 25, 2019 •

edited

Loading

rladuca Sep 25, 2019 •

edited

Loading

mmitche Sep 25, 2019

mmitche Sep 25, 2019

rladuca Sep 26, 2019

vatsan-madhavan Sep 26, 2019

mmitche Sep 26, 2019

mmitche commented Sep 26, 2019

dotnet-maestro bot commented Sep 26, 2019 •

edited

Loading

mmitche commented Sep 26, 2019

dotnet-maestro bot commented Sep 26, 2019 •

edited

Loading

mmitche commented Oct 3, 2019

dotnet-maestro bot commented Oct 3, 2019 •

edited

Loading

mmitche left a comment

mmitche commented Oct 30, 2019

azure-pipelines bot commented Oct 30, 2019

dotnet-maestro bot commented Oct 30, 2019 •

edited

Loading

mmitche commented Nov 22, 2019

rladuca commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019

mmitche commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019 •

edited

Loading

rladuca commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019 •

edited

Loading

mmitche commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019 •

edited

Loading

ghost commented Nov 22, 2019

		<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
		<add key="dotnet-wd" value="https://dotnetfeed.blob.core.windows.net/dotnet-windowsdesktop/index.json" />

[release/3.0] Update dependencies from dotnet/arcade #1955

[release/3.0] Update dependencies from dotnet/arcade #1955

Conversation

dotnet-maestro bot commented Sep 25, 2019 • edited Loading

From https://github.com/dotnet/arcade

dotnet-maestro bot commented Sep 25, 2019 • edited Loading

Auto-Merge Status

rladuca Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

mmitche Sep 25, 2019

Choose a reason for hiding this comment

mmitche Sep 25, 2019

Choose a reason for hiding this comment

rladuca Sep 26, 2019

Choose a reason for hiding this comment

vatsan-madhavan Sep 26, 2019

Choose a reason for hiding this comment

mmitche Sep 26, 2019

Choose a reason for hiding this comment

mmitche commented Sep 26, 2019

dotnet-maestro bot commented Sep 26, 2019 • edited Loading

Auto-Merge Status

mmitche commented Sep 26, 2019

dotnet-maestro bot commented Sep 26, 2019 • edited Loading

Auto-Merge Status

mmitche commented Oct 3, 2019

dotnet-maestro bot commented Oct 3, 2019 • edited Loading

Auto-Merge Status

mmitche left a comment

Choose a reason for hiding this comment

mmitche commented Oct 30, 2019

azure-pipelines bot commented Oct 30, 2019

dotnet-maestro bot commented Oct 30, 2019 • edited Loading

Auto-Merge Status

mmitche commented Nov 22, 2019

rladuca commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019

Auto-Merge Status

mmitche commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019 • edited Loading

Auto-Merge Status

rladuca commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019 • edited Loading

Auto-Merge Status

mmitche commented Nov 22, 2019

dotnet-maestro bot commented Nov 22, 2019 • edited Loading

Auto-Merge Status

ghost commented Nov 22, 2019

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

dotnet-maestro bot commented Sep 25, 2019 •

edited

Loading

dotnet-maestro bot commented Sep 25, 2019 •

edited

Loading

rladuca Sep 25, 2019 •

edited

Loading

dotnet-maestro bot commented Sep 26, 2019 •

edited

Loading

dotnet-maestro bot commented Sep 26, 2019 •

edited

Loading

dotnet-maestro bot commented Oct 3, 2019 •

edited

Loading

dotnet-maestro bot commented Oct 30, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 22, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 22, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 22, 2019 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.