Skip to content

Conversation

@Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented Apr 8, 2025

This fixes the leftover failures from #2418

Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the changes in 5.2 look breaking for us, tests pass without deprecation warnings (regarding django stuff)

Interesting things in the release notes:

  • reverse now allows passing a query and fragment string, so we don't need to manually concatenate things to URLs anymore (will open separate PR)
  • manage.py shell now supports automatic imports, making shell_plus superfluous. Maybe we can drop django-extensions (I don't think I'm using any of its functionality) Ah, we're still using reset_db sometimes, Django doesn't have anything native for that. Crazy.

@niklasmohrin niklasmohrin merged commit f6c2282 into e-valuation:main Apr 12, 2025
15 checks passed
@Kakadus Kakadus deleted the update-django branch April 14, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants