Skip to content

Conversation

@richardebeling
Copy link
Member

depends on #2427.

We still need django-extensions for reset_db. Maybe we can get by without it, I think we could then drop the dependency. There is one usage in reload_testdata and one usage in the load_production_backup script in the deployment repo.

Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging, we should also update the mention of shell_plus in the wiki

For reset_db, we could also roll our own implementation, but I don't know if we want to. On the one hand, it's really only DROP DATABASE X and CREATE DATABASE X ... (and we can remove a lot of the features of django_extensions' implementation. On the other hand, maybe we don't want to care about details with database auth and what not

@richardebeling richardebeling marked this pull request as ready for review April 14, 2025 16:33
@richardebeling richardebeling merged commit 24c125d into e-valuation:main Apr 14, 2025
13 of 15 checks passed
@richardebeling richardebeling deleted the django52 branch April 14, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants