Regression: CMAKE_LIBRARY_PATH=lib added to modulefiles

[Flamefire]

I've noticed that EB 5 starts adding CMAKE_LIBRARY_PATH+=lib (i.e. prepend etc) to the module files. I can't find why/how as this isn't necessary.
I only found:

self.CMAKE_LIBRARY_PATH = ['lib64'] # only needed for installations with standalone lib64
in ModuleLoadEnvironment

Is there some logic to avoid the symlink (lib64->lib) and just replace that?

The likely intention here (and behavior before) was to add CMAKE_LIBRARY_PATH+=lib64 if and only if lib doesn't exist.

Where could such logic be implemented in the new system? @lexming ?

[lexming]

We actually have specific test for this in

easybuild-framework/test/framework/easyblock.py

Line 503 in 68a38e5

# -- With files in lib and lib64 symlinks to lib

So part of the issue is that we are only testing that lib64 path is not added; and not lib.

In 5.0 we added a step in expand_module_search_path() that resolves those paths into their realpaths to ensure that we don't inject paths in the module file to external installation directories (from other easyconfigs). This was an issue with imkl and imkl-fftw AFAIR.

So we need to skip path resolution for this specific case, which we should do with a new easybuild.tools.modules.ModEnvVarType. I'll prepare a PR for this.