use new ModEnvVarType.STRICT_PATH_WITH_FILES with CMAKE_LIBRARY_PATH environment variable
#4858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid spurious default paths injected into generated module files
boegel
changed the title
ModEnvVarType.STRICT_PATH_WITH_FILES with CMAKE_LIBRARY_PATH environment variableModEnvVarType.STRICT_PATH_WITH_FILES with CMAKE_LIBRARY_PATH environment variable
boegel
modified the milestones:
next release (5.0.1 or 5.1.0),
release after next release (5.0.1 or 5.1.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4844
Avoid prepending spurious paths to
CMAKE_LIBRARY_PATHto defaultlibdirectory by adding a new stricter type forModuleEnvironmentVariablerequiring paths/globs that correspond to their real path, i.e. no jumping through symlinks.Unit test enhanced to catch the reported issue.