-
Notifications
You must be signed in to change notification settings - Fork 218
Use GCC instead of gompi for OpenBLAS in goolf-1.4.10 test toolchain. #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GCC instead of gompi for OpenBLAS in goolf-1.4.10 test toolchain. #2465
Conversation
This allows to use the golf toolchain within goolf-1.4.10, also added.
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartoldeman One small remark, lgtm otherwise.
You will need to fix the merge conflict in test/framework/scripts.py too though, since #2464 got merged first.
| versionsuffix = "-%s-%s%s" % (blaslib, blasver, blassuff) | ||
|
|
||
| dependencies = [(blaslib, blasver, blassuff)] | ||
| dependencies = [(blaslib, blasver, blassuff, ('GCC', '4.7.2'))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartoldeman There should be no need to hardcode to GCC here, see most recent ScaLAPACK easyconfigs like ScaLAPACK-2.0.2-gompic-2018b-OpenBLAS-0.3.1.eb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did my other comments get lost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other comments? Maybe that answers your question. ;)
|
Travis test report: 9/9 runs failed - see https://travis-ci.org/easybuilders/easybuild-framework/builds/421071564 Only showing partial log for 1st failed test suite run 2088.1;
(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid) |
|
@bartoldeman Hmm, not sure why the tests fail with |
|
Essentially it boils down to this: but without it: |
|
I have pushed a revert. |
| common_configopts + " --enable-single --enable-sse2 --enable-mpi", | ||
| common_configopts + " --enable-long-double --enable-mpi", | ||
| common_configopts + " --enable-quad-precision", | ||
| common_configopts + " --enable-sse2 --enable-mpi", # default as last |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of nitpicking... --enable-mpi should not be used in the serial FFTW build.
I know this is a test config that should never be built, but someone might find it and use it as an example...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. done
akesandgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thanks @bartoldeman |
This allows to use the golf toolchain within goolf-1.4.10, also added.