add support for --sanity-check-only + also run sanity check for extensions when using --module-only #3655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoldeman
previously requested changes
Apr 20, 2021
|
This probably needs more work to ensure that sanity checks for extensions are also done when using |
Yes, I just noticed that sanity checks for extensions are not run when using |
…ions is also run when using --sanity-check-only
ocaisa
reviewed
May 25, 2021
…ck-only or --module-only by initializing class instances for extensions if that wasn't done yet
…f exts_list is empty
…--module-only, unless --force is used
Co-authored-by: ocaisa <[email protected]>
boegel
changed the title
akesandgren
dismissed
bartoldeman’s stale review
Decision was made to not change.
akesandgren
requested changes
May 25, 2021
ocaisa
reviewed
May 26, 2021
Co-authored-by: ocaisa <[email protected]>
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.