add support for --skip-extensions #3702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaisa
reviewed
May 26, 2021
test/framework/options.py
Outdated
| @@ -5857,6 +5857,41 @@ def test_sanity_check_only(self): | |||
| regex = re.compile(error_pattern) | |||
| self.assertTrue(regex.search(error_msg), "Pattern '%s' should be found in: %s" % (regex.pattern, error_msg)) | |||
|
|
|||
| # failing sanity check for extension can be bypassed via --skip-extensions | |||
| self.eb_main(args + ['--skip-extensions'], do_build=True, return_error=True) | |||
There was a problem hiding this comment.
There's no test here is there, so what's the point?
There was a problem hiding this comment.
Yeah, what's the use of this?
There was a problem hiding this comment.
If the sanity check fails, then an error is raised, so this would cause the test to fail.
I can add another quick check for the module file after this though, to make that a bit more clear.
…-sanity-check-only
This comment has been minimized.
This comment has been minimized.
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3655 fixed the behavior of
--module-onlyto also cover extensions during the sanity check, which trumps the use case of generating a module file for anRinstallation when not all extensions have been installed.To restore this capability, the new
--skip-extensionsoptions can be used in combination with--module-only.It can also be used to install
R(orPython,Perl, etc.) without extensions first, and then enhance the installation viaeb --skipafterwards.fixes #3672