Skip to content

Conversation

@migueldiascosta
Copy link
Member

@boegel shall we also make sure all tests in github.py have github in the name, even though it looks redundant, so that all of those are also picked up by -m test.framework.suite github?

@boegel
Copy link
Member

boegel commented Jun 8, 2021

@boegel shall we also make sure all tests in github.py have github in the name, even though it looks redundant, so that all of those are also picked up by -m test.framework.suite github?

@migueldiascosta Yes, that makes sense to me, we should be able to easily run all tests related to the GitHub integration by filtering on test_github...

…b' in the test name so that they can be easily filtered
@migueldiascosta
Copy link
Member Author

@boegel with 5c521a9, we can run all tests related to github integration by filtering on github. If we want to filter on test_github, there are a few more tests that need to be renamed, let me know

@easybuilders easybuilders deleted a comment from boegelbot Jun 15, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants