make sure that test for --list-easyblocks is run first, before other tests that pick up additional easyblocks #3765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative order of
test_list_easyblocksandtest_xxx_include_easyblocks_from_prwas changed in #3730 whentest_xxx_include_easyblocks_from_prwas renamed totest_github_xxx_include_easyblocks_from_pr, but this broketest_list_easyblockswhen the tests that require a GitHub token are being run (not for PRs, only after a PR is merged).Simplest fix is to rename
test_list_easyblockstotest_000_list_easyblocksto ensure it's run first, since cleaning up the easyblock that get imported bytest_github_xxx_include_easyblocks_from_pris not trivial...This fixes the failing test in #3764 (which only happens there because no "external" branch is involved, the tests that require a GitHub token are run in that case).