make update_progress_bar a bit more robust by just doing nothing if the corresponding progress bar was not started (and making stopping of a non-started progress bar fatal) #3867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these changes, calling
update_progress_bar
when the progress bar was not started yet means trouble:Raising a
KeyError
is pretty nasty, since it gives zero info when it's reported without the traceback.In #3667 I've moved
update_progress_bar
intoEasyBlock.init_ext_instances
for example, which sometimes gets called without thestart_progress_bar
inextensions_step
.In that case, updating the progress bar doesn't make much sense, and making sure it's only called when an extensions progress bar is actually "active" would be tricky (and lead to ugly code).