-
Notifications
You must be signed in to change notification settings - Fork 211
stop using Ubuntu 20.4 in GitHub Actions workflows, use Ubuntu 22.04 instead #4783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…h Python 3.6 in Ubuntu 20.04 container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- ubuntu-20.04 | ||
- ubuntu-22.04 | ||
- ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This failure on Ubuntu 24.04 can be avoided with --filter-deps=binutils
Log file from a local build
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c huffman.c
If compilation produces errors, or a large number of warnings,
please read README.COMPILATION.PROBLEMS -- you might be able to
adjust the flags in this Makefile to improve matters.
Also in README.COMPILATION.PROBLEMS are some hints that may help
if your build produces an executable which is unable to correctly
handle so-called 'large files' -- files of size 2GB or more.
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c crctable.c
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c blocksort.c
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c randtable.c
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c compress.c
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c decompress.c
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c bzlib.c
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c bzip2.c
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -c bzip2recover.c
bzip2.c: In function ‘applySavedFileAttrToOutputFile’:
bzip2.c:1073:11: warning: ignoring return value of ‘fchown’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
1073 | (void) fchown ( fd, fileMetaInfo.st_uid, fileMetaInfo.st_gid );
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -Wall -Winline -O3 -fPIC -g -D_FILE_OFFSET_BITS=64 -o bzip2recover bzip2recover.o
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: /lib/x86_64-linux-gnu/libc.so.6: unknown type [0x13] section `.relr.dyn'
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libc.so.6 when searching for /lib/x86_64-linux-gnu/libc.so.6
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: cannot find /lib/x86_64-linux-gnu/libc.so.6
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: /lib/x86_64-linux-gnu/libc.so.6: unknown type [0x13] section `.relr.dyn'
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libc.so.6 when searching for /lib/x86_64-linux-gnu/libc.so.6
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: /lib64/ld-linux-x86-64.so.2: unknown type [0x13] section `.relr.dyn'
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: skipping incompatible /lib64/ld-linux-x86-64.so.2 when searching for /lib64/ld-linux-x86-64.so.2
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: cannot find /lib64/ld-linux-x86-64.so.2
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: /lib64/ld-linux-x86-64.so.2: unknown type [0x13] section `.relr.dyn'
/home/simon/work/eb/installpath/software/binutils/2.37/bin/ld: skipping incompatible /lib64/ld-linux-x86-64.so.2 when searching for /lib64/ld-linux-x86-64.so.2
collect2: error: ld returned 1 exit status
make: *** [Makefile:44: bzip2recover] Error 1
make: *** Waiting for unfinished jobs....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ gcc --version
gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ ld --version
GNU ld (GNU Binutils for Ubuntu) 2.42
Copyright (C) 2024 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
…ner + remove workarounds that were only needed in centos-7.9 container
Hmm, tests in new workflow file seem to hang, and eventually the workflow times out after ~6h Not sure what's going on there... |
…e added via a separate PR
I've fleshed out the separate workflow to keep running the tests with Python 3.6 to a separate PR, to unblock this one: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ubuntu 20.04 image for GitHub Actions is deprecated since 2025-02-01, see also actions/runner-images#11101