-
Notifications
You must be signed in to change notification settings - Fork 211
stop using Ubuntu 20.4 in GitHub Actions workflows, use Ubuntu 22.04 instead #4783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b3d5a7d
stop using Ubuntu 20.4 in GitHub Actions workflows, use Ubuntu 22.04 …
boegel 8516e1c
use python3.6 command instead of python3 in workflow to run tests wit…
boegel 796df9a
use --filter-deps in end2end test in fedora-41 or ubuntu-24.04 contai…
boegel ccd481a
remove custom workflow for running test suite with Python 3.6, will b…
boegel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,9 +11,9 @@ concurrency: | |
|
||
jobs: | ||
setup: | ||
runs-on: ubuntu-20.04 | ||
runs-on: ubuntu-22.04 | ||
outputs: | ||
lmod8: Lmod-8.7.6 | ||
lmod8: Lmod-8.7.58 | ||
modules4: modules-4.5.3 | ||
modules5: modules-5.3.1 | ||
steps: | ||
|
@@ -23,7 +23,8 @@ jobs: | |
runs-on: ubuntu-20.04 | ||
strategy: | ||
matrix: | ||
python: [3.6] | ||
# Python 3.10 is default in Ubuntu 22.04 | ||
python: ['3.10'] | ||
modules_tool: | ||
# use variables defined by 'setup' job above, see also | ||
# https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#needs-context | ||
|
@@ -33,39 +34,32 @@ jobs: | |
lc_all: [""] | ||
include: | ||
# Test different Python 3 versions with Lmod 8.x (with both Lua and Tcl module syntax) | ||
- python: 3.7 | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
- python: 3.8 | ||
- python: '3.7' | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
- python: 3.9 | ||
- python: '3.8' | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
- python: '3.10' | ||
- python: '3.9' | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
- python: '3.11' | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
- python: '3.12' | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
- python: '3.13' | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
# There may be encoding errors in Python 3 which are hidden when an UTF-8 encoding is set | ||
# Hence run the tests (again) with LC_ALL=C and Python 3.6 (or any < 3.7) | ||
- python: 3.6 | ||
modules_tool: ${{needs.setup.outputs.lmod8}} | ||
lc_all: C | ||
fail-fast: false | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2 | ||
|
||
- name: set up Python | ||
uses: actions/setup-python@v4 | ||
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0 | ||
with: | ||
python-version: ${{matrix.python}} | ||
architecture: x64 | ||
|
||
- name: install OS & Python packages | ||
run: | | ||
# for modules tool | ||
APT_PKGS="lua5.2 liblua5.2-dev lua-filesystem lua-posix tcl tcl-dev" | ||
APT_PKGS="lua5.3 liblua5.3-dev lua-filesystem lua-posix tcl tcl-dev" | ||
# for GitPython, python-hglib | ||
APT_PKGS+=" git mercurial" | ||
# dep for GC3Pie | ||
|
@@ -79,11 +73,6 @@ jobs: | |
sudo apt-get install $APT_PKGS | ||
fi | ||
|
||
# fix for lua-posix packaging issue, see https://bugs.launchpad.net/ubuntu/+source/lua-posix/+bug/1752082 | ||
# needed for Ubuntu 18.04, but not for Ubuntu 20.04, so skipping symlinking if posix.so already exists | ||
if [ ! -e /usr/lib/x86_64-linux-gnu/lua/5.2/posix.so ] ; then | ||
sudo ln -s /usr/lib/x86_64-linux-gnu/lua/5.2/posix_c.so /usr/lib/x86_64-linux-gnu/lua/5.2/posix.so | ||
fi | ||
# Python packages | ||
pip --version | ||
pip install --upgrade pip | ||
|
@@ -94,8 +83,8 @@ jobs: | |
pip install --upgrade setuptools | ||
fi | ||
# git config is required to make actual git commits (cfr. tests for GitRepository) | ||
git config --global user.name "Travis CI" | ||
git config --global user.email "[email protected]" | ||
git config --global user.name "Github Actions" | ||
git config --global user.email "[email protected]" | ||
git config --get-regexp 'user.*' | ||
|
||
- name: install GitHub token (if available) | ||
|
@@ -105,9 +94,9 @@ jobs: | |
# and are only run after the PR gets merged | ||
GITHUB_TOKEN: ${{secrets.CI_UNIT_TESTS_GITHUB_TOKEN}} | ||
run: | | ||
# only install GitHub token when testing with Lmod 8.x + Python 3.6 or 3.9, to avoid hitting GitHub rate limit | ||
# only install GitHub token when testing with Lmod 8.x + Python 3.9, to avoid hitting GitHub rate limit | ||
# tests that require a GitHub token are skipped automatically when no GitHub token is available | ||
if [[ "${{matrix.modules_tool}}" =~ 'Lmod-8' ]] && [[ "${{matrix.python}}" =~ 3.[69] ]]; then | ||
if [[ "${{matrix.modules_tool}}" =~ 'Lmod-8' ]] && [[ "${{matrix.python}}" =~ 3.9 ]]; then | ||
if [ ! -z $GITHUB_TOKEN ]; then | ||
SET_KEYRING="import keyrings.alt.file; keyring.set_keyring(keyrings.alt.file.PlaintextKeyring())" | ||
python -c "import keyring; $SET_KEYRING; keyring.set_password('github_token', 'easybuild_test', '$GITHUB_TOKEN')" | ||
|
@@ -197,9 +186,8 @@ jobs: | |
IGNORE_PATTERNS+="|skipping SvnRepository test" | ||
IGNORE_PATTERNS+="|requires Lmod as modules tool" | ||
IGNORE_PATTERNS+="|stty: 'standard input': Inappropriate ioctl for device" | ||
IGNORE_PATTERNS+="|CryptographyDeprecationWarning: Python 3.[567]" | ||
IGNORE_PATTERNS+="|CryptographyDeprecationWarning: Python 3.7" | ||
IGNORE_PATTERNS+="|from cryptography.* import " | ||
IGNORE_PATTERNS+="|CryptographyDeprecationWarning: Python 2" | ||
IGNORE_PATTERNS+="|Blowfish" | ||
IGNORE_PATTERNS+="|GC3Pie not available, skipping test" | ||
IGNORE_PATTERNS+="|CryptographyDeprecationWarning: TripleDES has been moved" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This failure on Ubuntu 24.04 can be avoided with
--filter-deps=binutils
Log file from a local build
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.