remove useless 'global' statements #4836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaisa
reviewed
Apr 2, 2025
| @@ -615,7 +611,6 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None, pr | |||
|
|
|||
| options, orig_paths = eb_go.options, eb_go.args | |||
|
|
|||
| global _log | |||
There was a problem hiding this comment.
This one is needed isn't it as you set it below
There was a problem hiding this comment.
Oh right, that's kind of hidden...
You're right.
|
Part of changes originally proposed have already been made in #4831, but none of the |
ocaisa
reviewed
Apr 2, 2025
| @@ -308,7 +308,6 @@ def process_eb_args(eb_args, eb_go, cfg_settings, modtool, testing, init_session | |||
| """ | |||
| options = eb_go.options | |||
|
|
|||
| global _log | |||
There was a problem hiding this comment.
I think this is needed as you set it in the following line
|
Both remaining So this PR is now useless, the required changes to get rid of the useless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalstatements are only required when a function or method redefines a global variable (like indry_run_set_dirsineasybuild.tools.build_log).This fixes a failing code style check caught by new version of
flake8: