Skip to content

remove useless 'global' statements #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

remove useless 'global' statements #4836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df7a162
remove useless 'global' statements
boegel Apr 2, 2025
854f557
Merge branch 'develop' into global
boegel Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions easybuild/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ def process_eb_args(eb_args, eb_go, cfg_settings, modtool, testing, init_session
"""
options = eb_go.options

global _log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is needed as you set it in the following line

# Unpack cfg_settings
(build_specs, _log, logfile, robot_path, search_query, eb_tmpdir, try_to_generate,
from_pr_list, tweaked_ecs_paths) = cfg_settings
Expand Down Expand Up @@ -612,7 +611,6 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None, pr

options, orig_paths = eb_go.options, eb_go.args

global _log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is needed isn't it as you set it below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, that's kind of hidden...

You're right.

(build_specs, _log, logfile, robot_path, search_query, eb_tmpdir, try_to_generate,
from_pr_list, tweaked_ecs_paths) = cfg_settings

Expand Down
Loading