-
Notifications
You must be signed in to change notification settings - Fork 211
implement exponential backoff in download_file
+ allow max. 6 attempts to download PR diff in fetch_files_from_pr
and fetch_files_from_commit
#4870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cify maximum number of download attempts
download_file
+ allow max. 8 attempts to download PR diff in fetch_files_from_pr
…(~10min) in fetch_files_from_pr + fetch_files_from_commit
I tested this with an "extreme" case, and it seems to hold up well:
The printed messages I added for debugging purposes, but it's probably wise to actually have those, so I'll update the PR accordingly. The first wait time is also not the intended 10 seconds, it straight goes to 2*10, need to fix that too. |
Just to add: I tried |
works well for me too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
download_file
+ allow max. 8 attempts to download PR diff in fetch_files_from_pr
download_file
+ allow max. 6 attempts to download PR diff in fetch_files_from_pr
download_file
+ allow max. 6 attempts to download PR diff in fetch_files_from_pr
download_file
+ allow max. 6 attempts to download PR diff in fetch_files_from_pr
and fetch_files_from_commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 2
workaround/fix for #4869