obtain PR/commit diff via GitHub API rather than downloading *.diff file via github.com
#4878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file via github.com
smoors
reviewed
May 15, 2025
smoors
reviewed
May 15, 2025
easybuild/tools/github.py
Outdated
| msg = f"Failed to download diff for commit {commit} of {github_account}/{github_repo} " | ||
| msg += " (after {max_attempts} attempts)" | ||
| raise EasyBuildError(msg, exit_code=EasyBuildExit.FAIL_GITHUB) | ||
| error_msg = f"Failed to download diff for {github_account}/{github_repo} PR #{pr}! (HTTP status code: {status})" |
There was a problem hiding this comment.
should print the commit here, not the PR
…i_get_request in fetch_files_from_commit and fetch_files_from_pr
…d from github_api_get_request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper fix for #4869 (way better than the workaround implemented in #4870)