-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Closed
Labels
electronissues related to the electron targetissues related to the electron target
Description
Bug Description:
When closing a Theia window, the path of the currently opened html file is checked against Theia's index.html:
| const safeToClose = !currentUrl.includes(frontendUri) || await this.checkSafeToStop(reason); |
However, if the current path contains a URL encodable character, this check fails, which results in OnWillStop handlers not being executed. Consequently, the user is never asked to confirm anything (unsaved editors, etc.) and the app simply closes.
Steps to Reproduce:
- Built a Theia app and place it in a path with a space
- Edit a file (disable auto save)
- Exit the application. The app should close without confirmation
Additional Information
- Operating System: macOS, Windows
- Theia Version: 1.25.0
Metadata
Metadata
Assignees
Labels
electronissues related to the electron targetissues related to the electron target