Fixed URL and FS path comparison on stop requests. #11229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
May 31, 2022
Otherwise, if the bundled app has space in the name, comparision fails. `currentUrl`: `file:///Applications/App%20Name.app/Contents/Resources/app/lib/index.html?port=57442#/path/to/workspace` `frontendUri`: `/Applications/App Name.app/Contents/Resources/app/lib/index.html` Closes eclipse-theia#11226 Co-authored-by: Akos Kitta <[email protected]> Co-authored-by: Mark Sujew <[email protected]> Signed-off-by: Akos Kitta <[email protected]>
msujew
approved these changes
May 31, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It fixes the
currentUrlvsfrontendUricomparison when handling stop requests in the electron app.For example:
currentUrl:file:///Applications/App%20Name.app/Contents/Resources/app/lib/index.html?port=57442#/path/to/workspacefrontentUri:/Applications/App Name.app/Contents/Resources/app/lib/index.htmlCloses #11226
How to test
Well, probably if you check out Theia to a path that contains spaces, the close handler does not work. At least, I could reproduce this with the TheiaBlueprint app.
Review checklist
Reminder for reviewers