Skip to content

Bump jsonschema to 4.17.1 #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pquentin
Copy link
Member

Since 4.2.0, jsonschema uses importlib.resources to load schemas, fixing an incompatibility with PyOxidizer.

See python-jsonschema/jsonschema#873

I tested this manually by removing an operation-type key, and got this as expected:

ERROR] Cannot race. Traceback (most recent call last):                                                                                                        
  File "/home/q/src/rally/esrally/track/loader.py", line 1059, in read                                                                                         
    jsonschema.validate(track_spec, self.track_schema)                                                                                                         
  File "/home/q/.virtualenvs/rally/lib64/python3.11/site-packages/jsonschema/validators.py", line 1120, in validate                                            
    raise error                                                                                                                                                
jsonschema.exceptions.ValidationError: 'operation-type' is a required property

Since 4.2.0, jsonschema uses importlib.resources to load schemas, fixing
an incompatibility with PyOxidizer.
@pquentin pquentin added this to the 2.7.1 milestone Nov 29, 2022
@pquentin pquentin self-assigned this Nov 29, 2022
@pquentin
Copy link
Member Author

Hmm, it allows compilation but breaks at runtime now: indygreg/PyOxidizer#457. Closing for now.

@pquentin pquentin closed this Nov 29, 2022
@pquentin pquentin deleted the bump-jsonschema branch February 16, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant