Skip to content

Load schemas via importlib.resources #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Nov 3, 2021

Fixes #871.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #873 (ffb5e06) into main (272b4f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          19       19           
  Lines        3119     3120    +1     
  Branches      377      377           
=======================================
+ Hits         3067     3068    +1     
  Misses         41       41           
  Partials       11       11           
Impacted Files Coverage Δ
jsonschema/_utils.py 98.19% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272b4f2...ffb5e06. Read the comment docs.

@Julian
Copy link
Member

Julian commented Nov 3, 2021

Thanks!

@Julian Julian merged commit 14b4fd7 into python-jsonschema:main Nov 3, 2021
@sevein sevein deleted the dev/issue-871-importlib-resources branch November 3, 2021 20:02
dae added a commit to ankitects/anki that referenced this pull request Nov 5, 2021
jsonschema 4.2 introduced a change that broke our current workaround
for in-memory support.

python-jsonschema/jsonschema#873
indygreg/PyOxidizer#457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load schemas via importlib.resources instead of pkgutil
2 participants