Fix to-device encryption info label #3208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/to-device-info-label
branch
from
ff818ab to
43297b5
Compare
toger5
commented
Apr 15, 2025
|
@BillCarsonFr yes, I will add a test. |
toger5
force-pushed
the
toger5/to-device-info-label
branch
from
43297b5 to
432be0c
Compare
toger5
force-pushed
the
toger5/to-device-info-label
branch
from
2821fd6 to
e1c5659
Compare
toger5
force-pushed
the
toger5/to-device-info-label
branch
from
0c22c98 to
5427c99
Compare
The label was shown also without checking that we use PerParticipantE2EE. Which is a prerequisite for toDevice transport. As a result the label was shown when not desired.
toger5
force-pushed
the
toger5/to-device-info-label
branch
from
9f04486 to
fba319e
Compare
toger5
force-pushed
the
toger5/to-device-info-label
branch
from
fba319e to
bf576ca
Compare
toger5
added a commit
that referenced
this pull request
May 19, 2025
* Fix to-device encryption info label The label was shown also without checking that we use PerParticipantE2EE. Which is a prerequisite for toDevice transport. As a result the label was shown when not desired. * rename: useLiveKit -> useLivekit * make the settings naming consistent
toger5
added a commit
that referenced
this pull request
May 19, 2025
* Fix to-device encryption info label (#3208) * Fix to-device encryption info label The label was shown also without checking that we use PerParticipantE2EE. Which is a prerequisite for toDevice transport. As a result the label was shown when not desired. * rename: useLiveKit -> useLivekit * make the settings naming consistent * lint The issue were caused by unifying the settings names. This change did not make it into the v0.11.0 branch and hence the backport needs to be adapted to use the old naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3201
The label was shown also without checking that we use PerParticipantE2EE. Which is a prerequisite for toDevice transport. As a result the label was shown when not desired.