only show to-device transport label in dev mode #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
approved these changes
Apr 22, 2025
toger5
force-pushed
the
toger5/to-device-info-label
branch
5 times, most recently
from
fba319e to
bf576ca
Compare
|
I hope its fine If i take over this PR since it is a bit of rebase work I hope you were not eager to do? If not just force push your version from your local branch. |
toger5
force-pushed
the
valere/only_show_todevice_label_in_dev_mode
branch
from
b157a51 to
6b3f704
Compare
toger5
force-pushed
the
valere/only_show_todevice_label_in_dev_mode
branch
from
7aa9794 to
f0463da
Compare
toger5
approved these changes
May 13, 2025
There was a problem hiding this comment.
@BillCarsonFr I wanted to get this off the table today so I have space for different things tomorrow.
It is basically still exactly your change.
Maybe you can still give it a quick scan and ping me tomorrow if there is any concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because based on #3208