-
Notifications
You must be signed in to change notification settings - Fork 224
Update README.md #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #276
Conversation
@@ -108,12 +120,6 @@ Check [examples](examples) and [interop](interop)(Interoperability Test) for som | |||
|
|||
2. [Benchmark](benchmark) followed by official spec | |||
|
|||
## Sponsors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this sponsorship still going on? If not, I think it makes more sense to remove that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I think @tony612 is the best person to answer this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay to remove this.
@@ -83,21 +98,18 @@ iex> {:ok, channel} = GRPC.Stub.connect("localhost:50051", interceptors: [GRPC.L | |||
|
|||
Check [examples](examples) and [interop](interop)(Interoperability Test) for some examples. | |||
|
|||
## TODO | |||
## Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that all the items on the list are done, I think it makes more sense to turn this section into a list of implemented features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this section altogether instead.
Or add a less itemized version in its place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a less itemized version in its place
I agree with you. What kind of items can we keep or what features are important to mention in the documentation? @polvalente
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a less itemized version in its place
I agree with you. What kind of items can we keep or what features are important to mention in the documentation? @polvalente
Supported request types (unary, stream in, stream out, bid stream), encoding types (grpc+web, grpc. etc), transport types (uds, tcp, tls), grpc reflection (in progress) , http transcoding... I think are important things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add anything that's still in progress. Otherwise, I agree with @sleipnir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add anything that's still in progress. Otherwise, I agree with @sleipnir
It was not my intention to say to put whatever is in progress. Just present an overview of what are the interesting features of any grpc library.
TODO
toFeatures