-
Notifications
You must be signed in to change notification settings - Fork 224
Update README.md #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #276
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,27 @@ | ||
# gRPC Elixir | ||
|
||
[](https://hex.pm/packages/grpc) | ||
[](https://travis-ci.org/elixir-grpc/grpc) | ||
[](https://app.travis-ci.com/elixir-grpc/grpc) | ||
[](https://github.com/elixir-grpc/grpc/actions) | ||
[](https://github.com/elixir-grpc/grpc/blob/master/LICENSE.md) | ||
[](https://github.com/elixir-grpc/grpc/commits/master) | ||
[](https://hex.pm/packages/elixir-grpc/grpc) | ||
|
||
An Elixir implementation of [gRPC](http://www.grpc.io/). | ||
|
||
**NOTICE: gun** | ||
## Table of contents | ||
|
||
The Gun library doesn't have a full 2.0 release yet, so we depend on `:grcp_gun 2.0.1` for now. | ||
This is the same as `:gun 2.0.0-rc.2`, but Hex doesn't let us depend on RC versions for releases. | ||
- [Notice](#notice) | ||
- [Installation](#installation) | ||
- [Usage](#usage) | ||
- [Features](#features) | ||
- [Benchmark](#benchmark) | ||
- [Contributing](#contributing) | ||
|
||
## Notice | ||
> __Note__ | ||
> The [Gun](https://github.com/ninenines/gun) library doesn't have a full 2.0 release yet, so we depend on `:grcp_gun 2.0.1` for now. | ||
This is the same as `:gun 2.0.0-rc.2`, but [Hex](https://hex.pm/) doesn't let us depend on RC versions for releases. | ||
|
||
## Installation | ||
|
||
|
@@ -30,7 +42,9 @@ The package can be installed as: | |
## Usage | ||
|
||
1. Generate Elixir code from proto file as [protobuf-elixir](https://github.com/tony612/protobuf-elixir#usage) shows(especially the `gRPC Support` section). | ||
|
||
2. Implement the server side code like below and remember to return the expected message types. | ||
|
||
```elixir | ||
defmodule Helloworld.Greeter.Server do | ||
use GRPC.Server, service: Helloworld.Greeter.Service | ||
|
@@ -71,6 +85,7 @@ end | |
``` | ||
|
||
4. Call rpc: | ||
|
||
```elixir | ||
iex> {:ok, channel} = GRPC.Stub.connect("localhost:50051") | ||
iex> request = Helloworld.HelloRequest.new(name: "grpc-elixir") | ||
|
@@ -83,37 +98,25 @@ iex> {:ok, channel} = GRPC.Stub.connect("localhost:50051", interceptors: [GRPC.L | |
|
||
Check [examples](examples) and [interop](interop)(Interoperability Test) for some examples. | ||
|
||
## TODO | ||
|
||
- [x] Unary RPC | ||
- [x] Server streaming RPC | ||
- [x] Client streaming RPC | ||
- [x] Bidirectional streaming RPC | ||
- [x] Helloworld and RouteGuide examples | ||
- [x] Doc and more tests | ||
- [x] Authentication with TLS | ||
- [x] Improve code generation from protos ([protobuf-elixir](https://github.com/tony612/protobuf-elixir) [#8](https://github.com/elixir-grpc/grpc/issues/8)) | ||
- [x] Timeout for unary calls | ||
- [x] Errors handling | ||
- [x] Benchmarking | ||
- [x] Logging | ||
- [x] Interceptors(See `GRPC.Endpoint`) | ||
- [x] [Connection Backoff](https://github.com/grpc/grpc/blob/master/doc/connection-backoff.md) | ||
- [x] Data compression | ||
- [x] Support other encoding(other than protobuf) | ||
## Features | ||
|
||
- Various kinds of RPC: | ||
- [Unary](https://grpc.io/docs/what-is-grpc/core-concepts/#unary-rpc) | ||
- [Server-streaming](https://grpc.io/docs/what-is-grpc/core-concepts/#server-streaming-rpc) | ||
- [Client-streaming](https://grpc.io/docs/what-is-grpc/core-concepts/#client-streaming-rpc) | ||
- [Bidirectional-streaming](https://grpc.io/docs/what-is-grpc/core-concepts/#bidirectional-streaming-rpc) | ||
- [TLS Authentication](https://grpc.io/docs/guides/auth/#supported-auth-mechanisms) | ||
- [Error handling](https://grpc.io/docs/guides/error/) | ||
- Interceptors(See [`GRPC.Endpoint`](https://github.com/elixir-grpc/grpc/blob/master/lib/grpc/endpoint.ex)) | ||
- [Connection Backoff](https://github.com/grpc/grpc/blob/master/doc/connection-backoff.md) | ||
- Data compression | ||
|
||
## Benchmark | ||
|
||
1. [Simple benchmark](examples/helloworld/README.md#Benchmark) by using [ghz](https://ghz.sh/) | ||
|
||
2. [Benchmark](benchmark) followed by official spec | ||
|
||
## Sponsors | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this sponsorship still going on? If not, I think it makes more sense to remove that section. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure. I think @tony612 is the best person to answer this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's okay to remove this. |
||
|
||
This project is being sponsored by [Tubi](https://tubitv.com/). Thank you! | ||
|
||
<img src="https://user-images.githubusercontent.com/1253659/37473536-4db44048-28a9-11e8-90d5-f8a2f5a8d53c.jpg" height="80"> | ||
|
||
## Contributing | ||
|
||
You contributions are welcome! | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that all the items on the list are done, I think it makes more sense to turn this section into a list of implemented features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this section altogether instead.
Or add a less itemized version in its place
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. What kind of items can we keep or what features are important to mention in the documentation? @polvalente
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supported request types (unary, stream in, stream out, bid stream), encoding types (grpc+web, grpc. etc), transport types (uds, tcp, tls), grpc reflection (in progress) , http transcoding... I think are important things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add anything that's still in progress. Otherwise, I agree with @sleipnir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not my intention to say to put whatever is in progress. Just present an overview of what are the interesting features of any grpc library.