breaking: upgrade ember-cli-addon-docs + ember-auto-import + dependencies #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndekeister-us
force-pushed
the
build/upgrade_ember-cli-addon-docs
branch
2 times, most recently
from
974c65c to
fe23c1a
Compare
ndekeister-us
force-pushed
the
build/upgrade_ember-cli-addon-docs
branch
from
fe23c1a to
2d55500
Compare
ndekeister-us
changed the title
ndekeister-us
force-pushed
the
build/upgrade_ember-cli-addon-docs
branch
from
2d55500 to
841e7f2
Compare
added 9 commits
September 17, 2021 15:27
ndekeister-us
force-pushed
the
build/upgrade_ember-cli-addon-docs
branch
from
841e7f2 to
70d8734
Compare
ndekeister-us
commented
Sep 17, 2021
| @@ -1,5 +1,5 @@ | |||
| #!/bin/bash | |||
| set -ev | |||
| if [ "${TEST_FRAMEWORK}" = "ember-mocha" ]; then | |||
| yarn remove ember-qunit 2>/dev/null && echo "n" | ember install ember-mocha || true | |||
| yarn remove ember-qunit 2>/dev/null && echo "n" | ember install ember-mocha || echo "n" | ember g ember-mocha || true | |||
There was a problem hiding this comment.
I'm not sure about the why it fails to generate ember-mocha blueprints via ember install ember-mocha now.
This "fix" work and force to generate them in case of fails, but feel free to share if you have an idea about the why / a better fix
|
Closing as not needed anymore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
Upgrade ember-cli-addon-docs-xxx dependencies
Upgrade
ember-cli-addon-docsandember-cli-addon-docs-yuidocto recent versionswe have at least one regression in documentation, due to a bug in ember-cli-addon-docs, the import path is not displayed anymore in "API Reference" section ; fixed via fix: display of import path ember-learn/ember-cli-addon-docs#922fixed in[email protected]Add ember-data as devDependencies to the project
It is now needed by recent versions of
ember-cli-addon-docs, see error thrown below when not presentUpdate ember-cli to 3.27
Fix following error
Refactor some stuff in the dummy app to fix some lint issues (AngleBrackets etc...)
Breaking
Upgrade to ember-auto-import 2+
Needed as
ember-cli-addon-docsis now usingember-auto-import@2, otherwise we have this errorIt is breaking because, if i'm not wrong, it will make apps using
ember-examto haveember-auto-import2+ , otherwise they will also have the error displayed aboveRefactor
Fix issue with
test:mochascriptsFor an unknown reason it now fails to generate blueprints for
ember-mochaviabin/install-test-framework.shModified the command to ensure it generate
ember-mochablueprints in case ofember install ember-mochafails to do itNote for reviewers
This PR fix issues with
ember-betaandember-canaryscenarios which are failing in this repo.These scenarios were failing because of an issue with liquid-fire dependencies not compatible with Ember 4.0 (
liquid-firehave some components using named outlets, see this job for example),liquid-fireis no more used in[email protected].Todo
yarn test > ./_testresults.txt-> _testresults.txttest:mochascript fails in the file above, but with last commit modifyingbin/install-test-framework.shfile it success