Skip to content

fix: display of import path #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ndekeister-us
Copy link
Contributor

@ndekeister-us ndekeister-us commented Sep 7, 2021

Fix display of import path

In v2.0.0 via https://github.com/ember-learn/ember-cli-addon-docs/pull/831/files#diff-7cd3d2b711dc840f44e1d648241f814f51ffef5405f9e4b0b474f11cebb1eb37R6, a refactor was made to use @showImportPaths instead of showImportPaths, but showImportPaths is not an attribute but a property from x-class component, see https://github.com/ember-learn/ember-cli-addon-docs/blob/master/addon/components/api/x-class/component.js#L16


Current behavior
Capture d’écran 2021-09-08 à 00 59 11

New behavior
Capture d’écran 2021-09-08 à 00 58 12


I really don't know if i should add some tests for this, as project is in maintenance mode and as far as i can see there is no test around that. But maybe i missed something, if you feel like we should start to add tests on these components i will add one.


Note that it is sure that ember-beta and ember-canary scenarios will not pass for various reasons, including this one ->

liquid-fire/templates/components/liquid-outlet.hbs: Assertion Failed: Named outlets were removed in Ember 4.0. See https://deprecations.emberjs.com/v3.x#toc_route-render-template for guidance on alternative APIs for named outlet use cases. ('liquid-fire/templates/components/liquid-outlet.hbs' @ L18:C10) 

@RobbieTheWagner
Copy link
Member

Thanks @ndekeister-us, good catch!

@RobbieTheWagner RobbieTheWagner merged commit 5ec2d98 into ember-learn:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants