Replace murmur hash with the fastest hash#545
Replace murmur hash with the fastest hash#545blackswanny wants to merge 2 commits intoemotion-js:masterfrom
Conversation
|
I have yarn tests failing. Do you use screen snapshots to compare? |
|
You are going to have massive snapshot failures because of the change in hash structure and algorithm. All the stylesheet snapshots will need to be updated. try this command
|
|
Have you tested these 2 hashes side by side with large strings before doing all of this though? The performance difference might not warrant that much work. |
|
I made a test. it's two strings with 10000 chars |
|
The benchmarks I showed in #544 had this hash function as |
|
@mitchellhamilton @tkh44 tests seems controversial. We have no exact winner. Once again my results on large strings. |



Here is another option. It is way faster than murmur and even murmur ver 2, which is used in another PR. The source code is at https://github.com/darkskyapp/string-hash
The original work is at http://www.cse.yorku.ca/%7Eoz/hash.html