Skip to content

Replace murmur hash with faster hash method#357

Open
blackswanny wants to merge 1 commit intothreepointone:masterfrom
blackswanny:master
Open

Replace murmur hash with faster hash method#357
blackswanny wants to merge 1 commit intothreepointone:masterfrom
blackswanny:master

Conversation

@blackswanny
Copy link

@blackswanny blackswanny commented Jan 17, 2018

As discussed in issues of this project and with similar emotion project collaborators, the murmur hash function is very slow and for the needs of this project can be replaced with faster hash.
The provided function is tested on real enterprise project also and provides up to 4 billion unique hashes

@jeroenransijn
Copy link

jeroenransijn commented Jan 23, 2018

This looks awesome! Our team has also been working on a package called https://github.com/segmentio/ui-box that implements a React Box primitive that tries to avoid calling a hash function at all when possible. However, this is not a replacement of glamor or anything — just might be a interesting resource to implement more speed improvements.

I am curious what the delta is in speed between your hash function and mrmrs hash?

@blackswanny
Copy link
Author

@jeroenransijn I can say only for our project, which we found 4 times faster (rendering of react). Possibly because we might have abused using of glamor, so in others it might be less.
emotion-js/emotion#536

@frontendphil
Copy link

Hey @blackswanny , since we at Signavio believe in this library we want to continue developing it further. Therefore, we've forked it and will release it as signavio-glamor. It would be awesome if you could direct your PR against our fork so that we can include it!

@blackswanny
Copy link
Author

@frontendphil I didn't find your repo in github. Also the research shown that it's not completely better, at least not in all browsers.

@frontendphil
Copy link

@blackswanny this is the repo: https://github.com/signavio/glamor Do you have some more statistics?

@blackswanny
Copy link
Author

blackswanny commented Sep 25, 2018

@frontendphil
My commit was pushed in other similar project.
emotion-js/emotion#536

See investigation here
emotion-js/emotion#545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants