-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Nodefs errno values don't match emscripten errno values on Windows #8882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
dschuff
added a commit
that referenced
this issue
Jun 27, 2019
FS.lstat returns 4058 on ENOENT... caused Sqlite to fail on an unhandled lstat error result. |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant. |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this issue
Dec 23, 2020
dschuff
added a commit
to dschuff/emscripten
that referenced
this issue
Dec 6, 2024
This seems to be another instance of emscripten-core#8882 where errno values don't match. This could be "fixed" by making the error check a little looser if we care about the behavior of NODERAWFS on Windows. For now just disable to unblock the rollers.
dschuff
added a commit
that referenced
this issue
Dec 6, 2024
This seems to be another instance of #8882 where errno values don't match. This could be "fixed" by making the error check a little looser if we care about the behavior of NODERAWFS on Windows. For now just disable to unblock the rollers.
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this issue
Dec 18, 2024
This seems to be another instance of emscripten-core#8882 where errno values don't match. This could be "fixed" by making the error check a little looser if we care about the behavior of NODERAWFS on Windows. For now just disable to unblock the rollers.
sbc100
added a commit
to sbc100/emscripten
that referenced
this issue
Dec 19, 2024
This test was recently added in emscripten-core#23136 but the test fails on windows due to errno mismatch. See emscripten-core#8882.
sbc100
added a commit
that referenced
this issue
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
e.g. on our current Windows bot, in
test_unistd_access
,test_unistd_misc
, andtest_unistd_unlink
, access to the "nonexistent" file returnsENOENT
which is 2 on posix and 4058 on Windows. NODEFS seems to pass the underlying errno value through from Node, which presumably passes it through from the platform.I assume this is a real problem since we use posix errno values in emscripten. Has this ever worked, or did it used to work in a different way?
The text was updated successfully, but these errors were encountered: