Fix mkdir("a/b/..") should return EEXIST
#23136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change `mkdir("a/b/..")` surprisingly makes a directory called `a/b/a`.
It should raise EEXIST.
sbc100
reviewed
Dec 14, 2024
sbc100
reviewed
Dec 14, 2024
sbc100
reviewed
Dec 14, 2024
sbc100
reviewed
Dec 14, 2024
sbc100
reviewed
Dec 14, 2024
sbc100
reviewed
Dec 16, 2024
sbc100
reviewed
Dec 16, 2024
sbc100
reviewed
Dec 18, 2024
sbc100
reviewed
Dec 18, 2024
sbc100
approved these changes
Dec 18, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
Before this change `mkdir("a/b/..")` surprisingly makes a directory
called `a/b/a`. It should raise EEXIST.
|
Looks like this is another case where the errno values don't match on Windows: I don't know if we want to run all the tests on Windows all the time, but I wonder if it makes sense to have an optional way to run extra tests on Windows for changes like this that might affect it. I know that's possible with the Chromium CI, maybe we can do it on CircleCI too. |
|
I think we just need to remember to mark all nodefs tests as |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 19, 2024
This test was recently added in emscripten-core#23136 but the test fails on windows due to errno mismatch. See emscripten-core#8882.
sbc100
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
mkdir("a/b/..")surprisingly makes a directory calleda/b/a. It should raise EEXIST.