Skip to content

Don't normalize path in PATH.basename() #23180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

hoodmane
Copy link
Collaborator

This brings it in line with the behavior of basename im coreutils and node.

This brings it in line with the behavior of basename im coreutils and node.
@sbc100
Copy link
Collaborator

sbc100 commented Dec 16, 2024

s/basename/PATH.basename/ in the PR title.

@hoodmane hoodmane changed the title Don't normalize path in basename Don't normalize path in PATH.basename() Dec 16, 2024
@sbc100 sbc100 enabled auto-merge (squash) December 16, 2024 20:23
@sbc100 sbc100 disabled auto-merge December 17, 2024 18:42
@sbc100 sbc100 merged commit 0f4d8b8 into emscripten-core:main Dec 17, 2024
26 of 28 checks passed
@hoodmane hoodmane deleted the basename-no-normalize branch December 18, 2024 10:24
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
This brings it in line with the behavior of basename im coreutils and
node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants