[FS] Run test_chmod in nodefs. NFC #23230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Dec 19, 2024
sbc100
reviewed
Dec 19, 2024
sbc100
approved these changes
Dec 24, 2024
sbc100
reviewed
Jan 6, 2025
| @@ -5525,9 +5525,10 @@ def test_fstatat(self): | |||
| @crossplatform | |||
| @with_all_fs | |||
| def test_stat_chmod(self): | |||
| if self.get_setting('NODERAWFS') and WINDOWS: | |||
| nodefs = '-DNODEFS' in self.emcc_args or '-DNODERAWFS' in self.emcc_args | |||
| if nodefs and WINDOWS: | |||
There was a problem hiding this comment.
It looks like we use to run this test with -DNODEFS on windows, but not after this change?
There was a problem hiding this comment.
Ooops, sorry I just saw that this change includes a change to the test (which presumably makes it no longer compatible with windows+nodefs). lgtm.
sbc100
approved these changes
Jan 6, 2025
hoodmane
changed the title
|
I'm repeatedly getting failures on |
|
It just failed 8 jobs in a row. |
|
Guess I should merge main since it looks like there is a relevant commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches a bug in
lchmodin NODEFS. The fix will be quite simple after #23058 is merged.