[FS] Make fstat work on file descriptors with no name in nodefs #23480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes fstat work on anonymous nodefs file descriptors. It is the last part of emscripten-core#23058.
|
@sbc100 would appreciate review on this one. |
sbc100
approved these changes
Jan 28, 2025
| // For stream getatrr: | ||
| // - arg is a native file descriptor | ||
| // - chmod, utimes, truncate are fs.fchmodSync, fs.futimesSync, fs.ftruncateSync | ||
| setattr(arg, node, attr, chmod, utimes, truncate, stat) { |
There was a problem hiding this comment.
I can't say I love this method of adding the opaque arg along with all the opts for it.. but I can't think of a nicer way, and I think its better than duplicating the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes fstat work on anonymous nodefs file descriptors. It is the last part of #23058.