[esm-integration] Add a new core test mode and fix or disable all tests #24288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
added a commit
that referenced
this pull request
May 9, 2025
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from #24288 See #24060
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 13, 2025
sbc100
added a commit
that referenced
this pull request
May 13, 2025
sbc100
force-pushed
the
esm_integration
branch
2 times, most recently
from
36c8a41 to
693533d
Compare
sbc100
changed the title
sbc100
force-pushed
the
esm_integration
branch
2 times, most recently
from
21c6eda to
874faab
Compare
sbc100
force-pushed
the
esm_integration
branch
9 times, most recently
from
bd8b23f to
b39ce99
Compare
dschuff
approved these changes
May 16, 2025
| @@ -1142,6 +1153,9 @@ workflows: | |||
| - test-modularize-instance: | |||
| requires: | |||
| - build-linux | |||
| - test-esm-integration: | |||
There was a problem hiding this comment.
do we need both the modularize-instance mode and the esm integration mode?
There was a problem hiding this comment.
For the time being I think it would be good. Maybe we can delete the former completely once this lands.
| @@ -7796,6 +7824,7 @@ def test_embind_dylink_visibility_hidden(self): | |||
| self.do_runf('main.cpp', 'done\n', emcc_args=['--bind']) | |||
|
|
|||
| @no_wasm2js('TODO: source maps in wasm2js') | |||
| @no_esm_integration('WASM_ESM_INTEGRATION is not compatible with dwarf output') | |||
There was a problem hiding this comment.
I think its because of the wasm-dis / wasm-as round-trip we have to do to modify the import names. Hopefully that can be fixed soon.
There was a problem hiding this comment.
Ah yeah. SGTM to have this now and fix soon.
brendandahl
reviewed
May 16, 2025
sbc100
force-pushed
the
esm_integration
branch
2 times, most recently
from
47d11b6 to
8779ae3
Compare
…all test. This is fairly larger change which can likely to split up before landing.
|
Looks like this broke CI because it can't find any tests matching the pattern. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 17, 2025
sbc100
added a commit
that referenced
this pull request
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.