This repository was archived by the owner on Oct 26, 2021. It is now read-only.
fix(sallyport): mark copy_into_slice unsafe #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
force-pushed
the
sallyport_into_slice
branch
from
1ffa4c4 to
411388e
Compare
haraldh
changed the title
haraldh
force-pushed
the
sallyport_into_slice
branch
from
411388e to
840f0b8
Compare
haraldh
force-pushed
the
sallyport_into_slice
branch
from
840f0b8 to
087a62d
Compare
haraldh
force-pushed
the
sallyport_into_slice
branch
from
087a62d to
1004fb1
Compare
Contributor
Author
|
Needs #188 first |
haraldh
force-pushed
the
sallyport_into_slice
branch
2 times, most recently
from
c57c5ff to
1856357
Compare
connorkuehl
previously approved these changes
Nov 30, 2020
lkatalin
reviewed
Nov 30, 2020
src/sallyport/mod.rs
Outdated
| Ok((c, dst)) | ||
| } | ||
|
|
||
| /// Copies data from a slice into the cursor buffer using self.alloc(). |
Contributor
There was a problem hiding this comment.
Unrelated to this PR, but should this not be "copies from a cursor buffer into a slice"?
src/sallyport/mod.rs
Outdated
|
|
||
| let mut slab_all = [0usize; 3]; | ||
|
|
||
| let c = unsafe { c.copy_into_slice::<usize>(4, &mut slab_all, 3) }?; |
Contributor
There was a problem hiding this comment.
Why is the src_len a 4 here? That is shorter than the total slab 1-3 values but longer than slab_all.
Contributor
Author
There was a problem hiding this comment.
That is the amount of elements the cursor should advance after copying.
`Cursor::copy_into_slice` has to be unsafe, otherwise it is possible to fill in a slice of e.g. bools with invalid values using safe rust code. This patch also adds a test calling `Cursor::copy_into_slice()` and simplifies the method by removing a parameter and calling existing methods. Signed-off-by: Harald Hoyer <[email protected]>
haraldh
force-pushed
the
sallyport_into_slice
branch
from
1856357 to
5594001
Compare
Contributor
Author
|
Ok, I didn't see the forest because of all the trees... simplified the method by removing |
lkatalin
approved these changes
Dec 1, 2020
connorkuehl
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(sallyport): mark copy_into_slice unsafe
Cursor::copy_into_slicehas to be unsafe, otherwise it is possible tofill in a slice of e.g. bools with invalid values using safe rust code.
This patch also adds a test calling
Cursor::copy_into_slice()andsimplifies the method by removing a parameter and calling existing
methods.