This repository was archived by the owner on Oct 26, 2021. It is now read-only.
fix build on nightly #188
Merged
fix build on nightly #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Merged
haraldh
changed the title
naked attribute from usermode fn
The `#[naked]` caused a rustc segfault. Remove it, because it was the wrong attribute anyway. Signed-off-by: Harald Hoyer <[email protected]>
`rerun_src()` doesn't need a return value, so remove it, because clippy will complain. Signed-off-by: Harald Hoyer <[email protected]>
`crt0setup()` never returns an `Err()`, so remove `Result` from the return parameter, otherwise clippy will complain. Signed-off-by: Harald Hoyer <[email protected]>
Suppress clippy warnings about `Result<()>`, where the functions never return an `Err()` for now. Signed-off-by: Harald Hoyer <[email protected]>
haraldh
force-pushed
the
no_naked_usermod
branch
from
44d2227 to
2c1d5d1
Compare
This was referenced Nov 26, 2020
ueno
approved these changes
Nov 29, 2020
mbestavros
approved these changes
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(keepldr): suppress clippy warnings
Suppress clippy warnings about
Result<()>, where the functions neverreturn an
Err()for now.fix(shim-sev): Function crt0setup does not need Result as return
crt0setup()never returns anErr(), so removeResultfrom thereturn parameter, otherwise clippy will complain.
fix(build): Remove unnecessary return value
rerun_src()doesn't need a return value, so remove it, because clippywill complain.
fix(shim-sev): remove
nakedattribute from usermode fnThe
#[naked]caused a rustc segfault. Remove it, because it was thewrong attribute anyway.