This repository was archived by the owner on Oct 26, 2021. It is now read-only.
Sev concurrent syscalls #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Needs #188 first |
haraldh
force-pushed
the
sev_concurrent_syscalls
branch
4 times, most recently
from
4b8fdd8 to
b604515
Compare
Rename `ALIGN_ABOVE_2MB` to `MAX_SETUP_SIZE` to reflect its meaning. Signed-off-by: Harald Hoyer <[email protected]>
haraldh
force-pushed
the
sev_concurrent_syscalls
branch
from
b604515 to
026c5a6
Compare
connorkuehl
suggested changes
Nov 30, 2020
src/backend/kvm/vm/builder.rs
Outdated
| pub const N_SYSCALL_BLOCKS: usize = | ||
| (MAX_SETUP_SIZE - size_of::<SetupRegionPre>()) / size_of::<Block>(); | ||
|
|
||
| pub struct Config; |
Contributor
There was a problem hiding this comment.
I think Config can be removed. Unless we want the number of syscall blocks to be configurable.
Because the setup area is limited in memory size, not each thread can get its own `sallyport::Block` to communicate with the host. Therefore a pool of blocks is reserved, which can be dynamically used by the shim indicating the actual block via the value passed in the IOPort. A future extension could reserve additional blocks via a enarx specific syscall. This patch also removes the now obsolete `backend::kvm::vm::Builder::Config`. Fixes: enarx-archive#156 Signed-off-by: Harald Hoyer <[email protected]>
haraldh
force-pushed
the
sev_concurrent_syscalls
branch
from
026c5a6 to
d768211
Compare
Contributor
Author
|
also removed |
connorkuehl
approved these changes
Nov 30, 2020
lkatalin
approved these changes
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(shim-sev): Use multiple sallyport::Block
Because the setup area is limited in memory size, not each thread can
get its own
sallyport::Blockto communicate with the host.Therefore a pool of blocks is reserved, which can be dynamically used
by the shim indicating the actual block via the value passed in the
IOPort.
A future extension could reserve additional blocks via a enarx specific
syscall.
This patch also removes the now obsolete
backend::kvm::vm::Builder::Config.Fixes: shim-sev: use multiple blocks for host <-> shim communication #156
fix(shim-sev): rename ALIGN_ABOVE_2MB
Rename
ALIGN_ABOVE_2MBtoMAX_SETUP_SIZEto reflect its meaning.