This repository was archived by the owner on Oct 26, 2021. It is now read-only.
feat(shim-sev): Implement get_attestation for SEV #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
force-pushed
the
sev_attestation
branch
3 times, most recently
from
c36157d to
04800bd
Compare
connorkuehl
suggested changes
Nov 16, 2020
haraldh
force-pushed
the
sev_attestation
branch
from
04800bd to
dfd1bc5
Compare
Contributor
Author
|
@connorkuehl updated |
Contributor
|
This all looks good to me. Each time we get closer to an MVP it just further reinforces the point that I think perhaps our VM builder platform could be a little more modular, otherwise it just looks like it starts to "grow" things. I'm cogitating on that. I'm wondering if at least in the hypervisor side the function parameters could be references instead of pointers, but I haven't looked around at the surrounding areas to see if the borrow checker would allow that. |
haraldh
force-pushed
the
sev_attestation
branch
from
dfd1bc5 to
e9cb423
Compare
haraldh
changed the title
haraldh
requested review from
ambaxter and
lkatalin
and removed request for
whitebrandy
haraldh
force-pushed
the
sev_attestation
branch
from
e9cb423 to
c53857c
Compare
haraldh
force-pushed
the
sev_attestation
branch
3 times, most recently
from
6c8f307 to
244a2cc
Compare
Contributor
Author
|
Needs #188 first |
haraldh
force-pushed
the
sev_attestation
branch
from
244a2cc to
df7db02
Compare
Contributor
Author
haraldh
force-pushed
the
sev_attestation
branch
2 times, most recently
from
4c9fe41 to
ea3574a
Compare
haraldh
force-pushed
the
sev_attestation
branch
5 times, most recently
from
5d2876b to
c660278
Compare
Inject the secret and provide it with the get_attestation call. Signed-off-by: Harald Hoyer <[email protected]>
haraldh
force-pushed
the
sev_attestation
branch
from
c660278 to
54a0607
Compare
Contributor
Author
|
Rebased to current master. |
Contributor
Author
|
@connorkuehl please re-review... you are still marked with |
connorkuehl
approved these changes
Dec 3, 2020
lkatalin
approved these changes
Dec 4, 2020
Contributor
lkatalin
left a comment
lkatalin
left a comment
There was a problem hiding this comment.
I'm not an expert on some of these details (esp. CBOR length), but looks okay to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject the secret and provide it with the get_attestation call.
Fixes: #159