fix(compartment-mapper,bundle-source): async parser support#3186
Open
fix(compartment-mapper,bundle-source): async parser support#3186
Conversation
Member
Author
📚 Pull Request Stack
Managed by gh-stack |
🦋 Changeset detectedLatest commit: d47070d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 16, 2026
boneskull
force-pushed
the
boneskull/async-parser
branch
from
f81a724 to
1463114
Compare
boneskull
force-pushed
the
boneskull/async-parser
branch
2 times, most recently
from
d46967c to
302f011
Compare
boneskull
force-pushed
the
boneskull/async-parser
branch
2 times, most recently
from
404d032 to
a423cb4
Compare
This was referenced Apr 30, 2026
boneskull
force-pushed
the
boneskull/async-parser
branch
from
0e4addb to
80a974c
Compare
This fixes the half-implemented type defs and support for async parsers by introducing `AsyncParserImplementation`. We needed sync-and-async-specific parse-mappers in `map-parser.js` and some type guards. A sync-parser-specific `SyncParserForLanguage` is introduced as well.
This adds missing tests to assert support of `import()` in ES module sources. As expected, it does not work within archives.
boneskull
force-pushed
the
boneskull/async-parser
branch
from
80a974c to
d47070d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the half-implemented type defs and support for async parsers by introducing
AsyncParserImplementation.We needed sync-and-async-specific parse-mappers in
map-parser.jsand some type guards.A sync-parser-specific
SyncParserForLanguageis introduced as well.Bonus: added some tests for
import()in ESM to@endo/compartment-mapper.