feat(evasive-transform): expose makeTransformCommentsVisitor#3217
Draft
boneskull wants to merge 1 commit intoboneskull/async-parserfrom
Draft
feat(evasive-transform): expose makeTransformCommentsVisitor#3217boneskull wants to merge 1 commit intoboneskull/async-parserfrom
boneskull wants to merge 1 commit intoboneskull/async-parserfrom
Conversation
Member
Author
|
Warning This PR is part of a stack and targets branch 📚 Pull Request Stack
Managed by gh-stack |
🦋 Changeset detectedLatest commit: 2b97a5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 30, 2026
b72e412 to
0041c99
Compare
0e4addb to
80a974c
Compare
0041c99 to
3f047de
Compare
Extracts `makeEvasiveTransformVisitor ` from `transformAst` and exports it via a new `./visitor.js` subpath. `transformAst` is reimplemented as a thin wrapper that calls `makeEvasiveTransformVisitor ` and traverses — no logic change, just inversion of control. Additional tidy-ups in the same diff: - `SourceType` now includes `commonjs`, and `parseAst` passes `allowReturnOutsideFunction: true` for that source type (which it does by default, if we didn't have it being set for `script` as well) - `SourceMapOption` type removed; its usages are replaced with `object | string` (actual referenced type does not exist) - Inline `import()` type references in JSDoc replaced with `@import` declarations at the top of each file. - `stripInternal: true` added to `tsconfig.json` so `@internal` items are excluded from generated `.d.ts` output. - `@types/babel__generator` and `@types/babel__traverse` (prod) added as dependencies (they were missing)
80a974c to
d47070d
Compare
3f047de to
2b97a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts
makeTransformCommentsVisitorfromtransformAstand exports it via a new./visitor.jssubpath.transformAstis reimplemented as a thin wrapper that callsmakeTransformCommentsVisitorand traverses — no logic change, just inversion of control.Additional tidy-ups in the same diff:
SourceTypenow includescommonjs, andparseAstpassesallowReturnOutsideFunction: truefor that source type (which it does by default, if we didn't have it being set forscriptas well)SourceMapOptiontype removed; its usages are replaced withobject | string(actual referenced type does not exist)import()type references in JSDoc replaced with@importdeclarations at the top of each file.stripInternal: trueadded totsconfig.jsonso@internalitems are excluded from generated.d.tsoutput.@types/babel__generatorand@types/babel__traverse(prod) added as dependencies (they were missing)