api: mark ServiceQuota as todo - #2249
Merged
Merged
Conversation
Signed-off-by: achoo30 <achoo30@bloomberg.net>
dosubot
Bot
added
the
size:XS
mathetake
approved these changes
Jun 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 144 144
Lines 21204 21204
=======================================
Hits 17960 17960
Misses 2162 2162
Partials 1082 1082 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aabchoo
enabled auto-merge (squash)
June 18, 2026 14:52
missBerg
added a commit
to missBerg/ai-gateway
that referenced
this pull request
Jun 18, 2026
…licy guide Failover on quota exhaustion and the backend-wide serviceQuota field are not yet enforced (failover awaits an unpublished Envoy release per envoyproxy#2261; serviceQuota enforcement is a known API TODO per envoyproxy#2249). Remove the failover claims entirely, and replace the Service-Wide Quota how-to and example with a short "not yet available" note. The guide now documents only what currently works, with a footgun warning for the exposed-but-inert field. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ServiceQuota currently needs to be implemented. The extension server does not inject the descriptor set but the rate limit config is properly configured. Adding it as a TODO/follow up.