Skip to content

api: mark ServiceQuota as todo #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aabchoo merged 2 commits into from
Jun 18, 2026
+6 −1
Merged

api: mark ServiceQuota as todo #2249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a7c1c1
mark ServiceQuota as todo
aabchoo Jun 17, 2026
3499d43
Merge branch 'main' into aaron/mark-service-quota-todo
aabchoo Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/v1alpha1/quota_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ type QuotaPolicySpec struct {
// Quota for all models served by AIServiceBackend(s). This value can be overridden for specific models using the "PerModelQuotas"
// configuration.
//
// Currently, the rate limit configuration is properly set up, but the descriptor set is not being set in the Envoy Configuration
// TODO: Add changes in the extension server to support ServiceQuota enforcement.
//
// +optional
ServiceQuota ServiceQuotaDefinition `json:"serviceQuota,omitempty"`
// PerModelQuotas specifies quota for different models served by the AIServiceBackend(s) where this
Expand Down
2 changes: 2 additions & 0 deletions manifests/charts/ai-gateway-crds-helm/templates/aigateway.envoyproxy.io_quotapolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@ spec:
description: |-
Quota for all models served by AIServiceBackend(s). This value can be overridden for specific models using the "PerModelQuotas"
configuration.

Currently, the rate limit configuration is properly set up, but the descriptor set is not being set in the Envoy Configuration
properties:
costExpression:
description: |-
Expand Down
2 changes: 1 addition & 1 deletion site/docs/api/api.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,7 +2337,7 @@ QuotaPolicySpec specifies rules for computing token based costs of requests.
name="serviceQuota"
type="[ServiceQuotaDefinition](#github.1485827954.workers.dev-envoyproxy-ai-gateway-api-v1alpha1-servicequotadefinition)"
required="false"
description="Quota for all models served by AIServiceBackend(s). This value can be overridden for specific models using the `PerModelQuotas`<br />configuration."
description="Quota for all models served by AIServiceBackend(s). This value can be overridden for specific models using the `PerModelQuotas`<br />configuration.<br />Currently, the rate limit configuration is properly set up, but the descriptor set is not being set in the Envoy Configuration"
/><ApiField
name="perModelQuotas"
type="[PerModelQuota](#github.1485827954.workers.dev-envoyproxy-ai-gateway-api-v1alpha1-permodelquota) array"
Expand Down